Browse Source

not sure if this fix should remain, think it was to fix NOTE comment

ssh-lenovo
John-Mark Gurney 2 years ago
parent
commit
2a1de3374f
2 changed files with 5 additions and 2 deletions
  1. +4
    -0
      NOTES.md
  2. +1
    -2
      vlanmang/__init__.py

+ 4
- 0
NOTES.md View File

@@ -60,6 +60,10 @@ NetGear GS108Tv2

Does not list VLAN 1 under dot1qVlanStaticName.

It appears that firmware v5.4.2.30 will not set a port to be untagged
via SNMP. If after configuring via SNMP, a UI visit appears to be
required, toggle the setting and hit apply.

NetGear GS724TPv2
-----------------



+ 1
- 2
vlanmang/__init__.py View File

@@ -290,9 +290,8 @@ def checkchanges(module):
switchuntagged = switch.getuntagged(*vlans)
untagged = getuntagged(i.vlanconf, lufun)
for i in vlans:
if not _cmpbits(switchegress[i], egress[i]):
if not _cmpbits(switchegress[i], egress[i]) or not _cmpbits(switchuntagged[i], untagged[i]):
res.append((switch, name, 'setegress', i, egress[i], switchegress[i]))
if not _cmpbits(switchuntagged[i], untagged[i]):
res.append((switch, name, 'setuntagged', i, untagged[i], switchuntagged[i]))

return res


Loading…
Cancel
Save